Add Expr::try_as_col, deprecate Expr::try_into_col (speed up optimizer)
#10448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
sadboy
approved these changes
May 12, 2024
|
Thanks @sadboy 🙏 |
alamb
changed the title
Expr::try_as_col, deprecate Expr::try_into_colExpr::try_as_col, deprecate Expr::try_into_col (speed up optimizer)
tustvold
approved these changes
May 13, 2024
Yes indeed -- baby steps. Thank you for the review @tustvold Another thing that would likely help non trivially would be to introduce a version of |
alamb
commented
May 13, 2024
| accumu.insert(l.try_into_col()?); | ||
| accumu.insert(r.try_into_col()?); | ||
| let Some(l) = l.try_as_col().cloned() else { | ||
| return internal_err!( |
There was a problem hiding this comment.
I think making the error here (rather than in try_into_col) results in a more specific error message that will be easier to debug if we ever hit it
findepi
pushed a commit
to findepi/datafusion
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #9637
I ran into this while working on #10444
Rationale for this change
There are places in the code that check if an expr is a column by using
Expr::try_into_col()which has two potential performance problems:Column(and thus a string) to check if an expr is aExpr::ColumnDataFusionErrorto check if an expr is not aExpr::ColumnWhat changes are included in this PR?
Expr::try_as_colExpr::try_into_colExpr::try_into_colAre these changes tested?
By existing tests
Are there any user-facing changes?
A new function / less required copying
I doubt we will see any significant performance changes however it does reduce allocations during planning